Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #20

Merged
merged 4 commits into from
Jun 4, 2019
Merged

Various fixes #20

merged 4 commits into from
Jun 4, 2019

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Jun 4, 2019

This fixes #19 and makes showtable work for everything that's Tables.tableable (which includes Arrays, for example).

I'm not sure if this representation is what we want. Compare DataFrames default printing:

3×1 DataFrame
│ Row │ a       │
│     │ Union…⍰ │
├─────┼─────────┤
│ 1   │ 1       │
│ 2   │ missing │
│ 3   │         │

to
image
I was playing around with nothing => - or n/a and missing => ? but it's not clear to me if those are actually any better.

@pfitzseb pfitzseb changed the title explicitly print nothing/missing Various fixes Jun 4, 2019
@pfitzseb pfitzseb force-pushed the sp/nothingmissing branch from 7cd0e1a to aac8671 Compare June 4, 2019 14:55
@pfitzseb pfitzseb merged commit 888ce65 into master Jun 4, 2019
@pfitzseb pfitzseb deleted the sp/nothingmissing branch June 4, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nothing can't be printed
1 participant