Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add the option to test tangent types #186

Closed
wants to merge 1 commit into from
Closed

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Jul 2, 2021

Companion to JuliaDiff/ChainRules.jl#459.

We might want this? To check that the rule returns the correct tangent types.

Note that this needs to be made non-breaking by changing the default to false. We can flip the sign with the next breaking release.

@oxinabox
Copy link
Member

oxinabox commented Jul 2, 2021

I'm not sure.
Possibly for testing this we have something better.
For example checking that you can add it to the primal and the result has structual zeros in the same place the primal does.
(indicated for Diagonal by being the right type still)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants