filled in top and bottom of 3d cylinder

src/decompose.jl

@@ -399,13 +399,15 @@ function decompose(PT::Type{Point{3, T}}, c::Cylinder{3}, resolution = 30) where
     isodd(resolution) && (resolution = 2 * div(resolution, 2))
     resolution = max(8, resolution); nbv = div(resolution, 2)
     M = rotation(c); h = height(c)
-    position = 1; vertices = Vector{PT}(undef, 2 * nbv)
+    position = 1; vertices = Vector{PT}(undef, 2 * nbv+2)
     for j = 1:nbv
         phi = T((2π * (j - 1)) / nbv)
         vertices[position] = PT(M * Point{3, T}(c.r * cos(phi), c.r * sin(phi),0)) + PT(c.origin)
         vertices[position+1] = PT(M * Point{3, T}(c.r * cos(phi), c.r * sin(phi),h)) + PT(c.origin)
         position += 2
     end
+    vertices[end-1] = PT(c.origin)
+    vertices[end] = PT(c.extremity)
     return vertices
 end
 
@@ -416,13 +418,18 @@ end
 function decompose(::Type{FT}, c::Cylinder{3}, facets = 30) where FT <: Face
     isodd(facets) ? facets = 2 * div(facets, 2) : nothing
     facets < 8 ? facets = 8 : nothing; nbv = Int(facets / 2)
-    indexes = Vector{FT}(undef, facets); index = 1
+    indexes = Vector{FT}(undef, facets)
+    index = 1
     for j = 1:(nbv-1)
         indexes[index] = (index + 2, index + 1, index)
         indexes[index + 1] = ( index + 3, index + 1, index + 2)
         index += 2
     end
     indexes[index] = (1, index + 1, index)
     indexes[index + 1] = (2, index + 1, 1)
+
+    for i = 1:length(indexes)
+        i%2 == 1 ? push!(indexes, (indexes[i][1], indexes[i][3], 2*nbv+1)) : push!(indexes,(indexes[i][2], indexes[i][1], 2*nbv+2))
+    end
     return indexes
 end

test/cylinder.jl

@@ -55,7 +55,9 @@
             (-2.535533905932737,5.535533905932738,2.9999999999999996),
             (0.46446609406726314,8.535533905932738,6.0),
             (-1.0412414523193152,-0.04124145231931431,7.0824829046386295),
-            (1.9587585476806848,2.9587585476806857,10.08248290463863)
+            (1.9587585476806848,2.9587585476806857,10.08248290463863),
+            (1,2,3),
+            (4,5,6)
         ]
         @test decompose(Point3{Float64},s,8) ≈ positions
         faces = Face[
@@ -66,7 +68,16 @@
             (7, 6, 5),
             (8, 6, 7),
             (1, 8, 7),
-            (2, 8, 1)
+            (2, 8, 1),
+
+            (3, 1, 9),
+            (2, 4, 10),
+            (5, 3, 9),
+            (4, 6, 10),
+            (7, 5, 9),
+            (6, 8, 10),
+            (1, 7, 9),
+            (8, 2, 10)
         ]
         @test faces == decompose(Face{3, Int}, s, 6)
         m = GLPlainMesh(s, 8)