-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken syntax on 0.5 #245
Conversation
Yep. |
CI seems to be unhappy. |
Seems like an unrelated failure? |
Only on Mac. Seems to be unrelated? |
Some Mac users have strong oppinions on that... I'm not an expert on this, but could it be another Homebrew hiccup?
|
it worked a few weeks ago, ref https://travis-ci.org/JuliaGraphics/Gtk.jl/builds/142129851 - but Homebrew.jl has gone through some overhauls recently |
@tkelman: So, is it ok to ignore this for the current PR? The fix looks ok. |
@lobingera my point was that if it only fails on mac then it is likely not the PR's fault since the change should be OS agnostic. |
@KristofferC I agree. But if building gtk3+ on travis creates a problem, another issue should be opened. |
Please do. |
looks correct @stevengj?
ref JuliaLang/julia#17393 (comment)