Updates for new type system and tuple-printing #21
Conversation
| @@ -4,6 +4,7 @@ module ImageCore | |||
|
|
|||
| using Colors, FixedPointNumbers, MappedArrays, Graphics, ShowItLikeYouBuildIt | |||
| using OffsetArrays # for show.jl | |||
| using ColorTypes: colorant_string | |||
There was a problem hiding this comment.
should be listed in REQUIRE if used directly
There was a problem hiding this comment.
Indeed it should. Damn, you're impressive.
There was a problem hiding this comment.
observant, picky, OCD perhaps
this direct dependency stuff will hopefully be baked into the way Pkg3 environments work so it'll get auto-detected
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 90.77% 90.22% -0.55%
==========================================
Files 9 9
Lines 477 481 +4
==========================================
+ Hits 433 434 +1
- Misses 44 47 +3
Continue to review full report at Codecov.
|
|
Switched to a workaround for JuliaLang/julia#20568. |
The `include_string` stuff is to work around an inference problem on 0.5 Still not inferred properly on 0.6.
|
This requires a new tag in OffsetArrays to pass tests, and at least some versions of 0.6 have an inference problem with the StackedViews tests (not our CI, apparently). But, this allows ImageCore to at least build on 0.6 and perform most of its duties, which should end the next main reason the whole Images suite is not passing on 0.6. |
This fixes several breakages on julia 0.6.
Needs JuliaLang/julia#20568 andaffected by JuliaLang/julia#20569. But at least this way we're better prepared.