Consistently parse all boolean environment variables

[giordano]

Note: this is basically only checking the truthy values, so values like "truw" would silently be parsed as a falsy value, but as far as I can tell that's what's happening at the moment anyways, so I don't think there is any practical change.

Address #2705 (comment).

[StefanKarpinski]

I think there's some spots in PlatformEngines where we do this too. Might want to allow passing whether the default should be true or false? Although if the default is always false, I guess no need.

[giordano]

I think there's some spots in PlatformEngines where we do this too.

Oh yes, I saw

Pkg.jl/src/PlatformEngines.jl

Lines 228 to 231 in 0d6a726

	val = get(ENV, var, nothing)
	state = val === nothing ? "n" :
	lowercase(val) in ("true", "t", "1", "yes", "y") ? "t" :
	lowercase(val) in ("false", "f", "0", "no", "n") ? "f" : "o"

but that uses a three-value logic, I wasn't sure whether to add that to the helper function bool_env, it'd require all other places to guard nothing values.

Might want to allow passing whether the default should be true or false? Although if the default is always false, I guess no need.

Added the default value (which seems to be always false at the moment JULIA_PKG_PRECOMPILE_AUTO defaults to true) 👍

[giordano]

Bump 🙂

[IanButterworth]

Perhaps

Suggested change

	ignore_hash = bool_env("JULIA_PKG_IGNORE_HASHES")
	ignore_hash = get_bool_env("JULIA_PKG_IGNORE_HASHES")

[giordano]

Not sure what you mean, is this a suggestion to rename the function?

[IanButterworth]

Yeah. Just a minor suggestion

[IanButterworth]

I think we'd want env vars that exist for shared functionality in both LTS and new releases to behave the same, so I'm going to mark this for backport