Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store temp packages in packages/temp #4188

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Operations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,11 @@ function install_archive(
version_path::String;
io::IO=stderr_f()
)::Bool
depot_temp = mkpath(joinpath(dirname(dirname(dirname(version_path))), "temp"))
# Because we use `mv_temp_dir_retries` which uses `rename` not `mv` it can fail if the temp
# files are on a different fs. So use a temp dir in the same depot dir as some systems might
# be serving different parts of the depot on different filesystems via links i.e. pkgeval does this.
depot_temp = mkpath(joinpath(dirname(dirname(version_path)), "temp")) # .julia/packages/temp

tmp_objects = String[]
url_success = false
for (url, top) in urls
Expand Down