Skip to content

Commit 61a291b

Browse files
authoredFeb 22, 2017
Merge pull request #20722 from JuliaLang/jb/nontypebounds
tolerate non-types as Tuple parameters better
2 parents 35ce0fd + e8d2d95 commit 61a291b

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed
 

‎src/subtype.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ static int is_leaf_bound(jl_value_t *v)
414414
}
415415
return 1;
416416
}
417-
return 0;
417+
return !jl_is_type(v) && !jl_is_typevar(v);
418418
}
419419

420420
static jl_value_t *widen_Type(jl_value_t *t)

‎test/subtype.jl

+3
Original file line numberDiff line numberDiff line change
@@ -938,3 +938,6 @@ ftwoparams(::TwoParams{<:Real,<:Real}) = 3
938938
# supertype operator
939939
@test !(Int >: Integer)
940940
@test Integer >: Int
941+
942+
# tolerate non-types in Tuples
943+
@test typeintersect(Tuple{0}, Tuple{T} where T) === Tuple{0}

2 commit comments

Comments
 (2)

nanosoldier commented on Feb 22, 2017

@nanosoldier
Collaborator

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

nanosoldier commented on Feb 22, 2017

@nanosoldier
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.