Skip to content

Commit c38a5a3

Browse files
nalimilantkelman
authored andcommitted
Only download UnicodeData.txt once (#19794)
Verify the checksums on every run, but only download the file if missing. Also fix path in error message when checksum doesn't match by tweaking jlchecksum a bit so that it doesn't assume all files are saved into deps/srccache.
1 parent 205c12b commit c38a5a3

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

deps/tools/jlchecksum

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ checksum_error()
3737
echo " But \`$CHECKSUM_PROG\` results in:" >&2
3838
print_hash "$CURR_CHECKSUM"
3939
echo " This can happen due to bad downloads or network proxies, please check your" >&2
40-
echo " network proxy/firewall settings and delete deps/srccache/$BASENAME" >&2
40+
echo " network proxy/firewall settings and delete" >&2
41+
echo " $(realpath $ARG1)" >&2
4142
echo " to force a redownload when you are ready" >&2
4243
echo "===============================================================================" >&2
4344
exit 2

doc/Makefile

+3-1
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ help:
1818
@echo " doctest to run all doctests embedded in the documentation"
1919
@echo " check to run linkcheck and doctests"
2020

21-
deps:
21+
UnicodeData.txt:
2222
$(JLDOWNLOAD) http://www.unicode.org/Public/9.0.0/ucd/UnicodeData.txt
23+
24+
deps: UnicodeData.txt
2325
$(JLCHECKSUM) UnicodeData.txt
2426

2527
clean:

0 commit comments

Comments
 (0)