Only download UnicodeData.txt once #19794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Dec 31, 2016
| @@ -37,7 +37,8 @@ checksum_error() | |||
| echo " But \`$CHECKSUM_PROG\` results in:" >&2 | |||
| print_hash "$CURR_CHECKSUM" | |||
| echo " This can happen due to bad downloads or network proxies, please check your" >&2 | |||
| echo " network proxy/firewall settings and delete deps/srccache/$BASENAME" >&2 | |||
| echo " network proxy/firewall settings and delete" | |||
There was a problem hiding this comment.
this should also go to stderr
Verify the checksums on every run, but only download the file if missing. Also fix path in error message when checksum doesn't match by tweaking jlchecksum a bit so that it doesn't assume all files are saved into deps/srccache.
nalimilan
force-pushed
the
nl/download
branch
from
2e27e3f to
43fbfee
Compare
tkelman
approved these changes
Dec 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify the checksums on every run, but only download the file if missing.
Also fix path in error message when checksum doesn't match by tweaking
jlchecksum a bit so that it doesn't assume all files are saved into
deps/srccache.