Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsefloat/parseint as call #10594

Closed
simonbyrne opened this issue Mar 21, 2015 · 5 comments
Closed

parsefloat/parseint as call #10594

simonbyrne opened this issue Mar 21, 2015 · 5 comments

Comments

@simonbyrne
Copy link
Contributor

The BigInt and BigFloat constructors both accept string arguments:

BigInt("12")
BigFloat("1.2")

However for bitstypes (Int, Float64, etc), we require parsefloat and parseint for the same functionality. What about overloading call instead?
@StefanKarpinski
Copy link
Member

+1

1 similar comment
@ViralBShah
Copy link
Member

👍

simonbyrne added a commit that referenced this issue Mar 21, 2015
@simonbyrne
Use call for integer to numeric conversion (#10594)
a7a2e6d
@simonbyrne simonbyrne mentioned this issue Mar 21, 2015
Closed
@simonster simonster mentioned this issue Apr 10, 2015
Closed
@dpsanders
Copy link
Contributor

👍

@JeffBezanson
Copy link
Member

See #10599 (comment). I may have to 👎 this.

@StefanKarpinski
Copy link
Member

I think we could have a big"1.2" macro instead of this and scrap the string constructors for big ints and floats.

@simonbyrne simonbyrne mentioned this issue Apr 23, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@StefanKarpinski @dpsanders @ViralBShah @JeffBezanson @simonbyrne