Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isvalid(::String) is not defined but documented. #17467

Closed
yuyichao opened this issue Jul 17, 2016 · 1 comment
Closed

isvalid(::String) is not defined but documented. #17467

yuyichao opened this issue Jul 17, 2016 · 1 comment
Assignees
Labels
strings "Strings!"

Comments

@yuyichao
Copy link
Contributor

Ref #16590 (comment) and JuliaLang/IJulia.jl#441 (Opening an issue so that it is not lost).

I'm not sure what's the decision (I assume the method was deleted by accident?) but we should either fix the document (for isvalid(value) -> Bool) or add the method back.

@stevengj
Copy link
Member

stevengj commented Jul 19, 2016

Note that we still have isvalid(String, s::String), so fixing this issue would be as simple as adding back isvalid(s::String) = isvalid(String, s) (or the more generic isvalid{T}(x::T) = isvalid(T, x) if we want to support this pattern for isvalid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings "Strings!"
Projects
None yet
Development

No branches or pull requests

4 participants