Failure in pkg tests

[ararslan]

The following error is showing up in CI on all platforms:

Worker 3 failed running test pkg:
Some tests did not pass: 105 passed, 0 failed, 1 errored, 0 broken.pkg: Error During Test
  Got an exception of type LoadError outside of a @test
  LoadError: ArgumentError: argument to Flatten must contain at least one iterator
  start at ./iterators.jl:610
  grow_to! at ./array.jl:445
  intersect at ./pkg/types.jl:44
  push! at ./pkg/types.jl:183
  requirements at ./pkg/query.jl:34
  resolve at ./pkg/entry.jl:481
  edit at ./pkg/entry.jl:30
  #1 at ./task.jl:335
  while loading /tmp/julia/share/julia/test/pkg.jl, in expression starting on line 39

Test Summary:    | Pass  Error  Total
  Overall        |  109      1    110
    libgit2-online |    4             4
    pkg          |  105      1    106
    FAILURE
Error in testset pkg:
Error During Test
  Got an exception of type LoadError outside of a @test
  LoadError: ArgumentError: argument to Flatten must contain at least one iterator
  start at ./iterators.jl:610
  grow_to! at ./array.jl:445
  intersect at ./pkg/types.jl:44
  push! at ./pkg/types.jl:183
  requirements at ./pkg/query.jl:34
  resolve at ./pkg/entry.jl:481
  edit at ./pkg/entry.jl:30
  #1 at ./task.jl:335
  while loading /tmp/julia/share/julia/test/pkg.jl, in expression starting on line 39
ERROR: LoadError: Test run finished with errors
while loading /tmp/julia/share/julia/test/runtests.jl, in expression starting on line 38

[tkelman]

doesn't fail with a 4-day-old master, so cc @carlobaldassi

[tkelman]

bisects to d054d36 - must be changes in metadata hitting new code paths that weren't causing a problem until now

[carlobaldassi]

Sorry, not sure how I missed this...

[tkelman]

thanks for the fix. is it possible for the metadata situation that caused this to change and no longer cause an issue with the old code? if so, a targeted test might be good if possible to write one