- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linear algebra documentation #2593
Comments
Sure. Feel free to change the names. I'll have a look at the documentation. |
Need to also document |
Eigen -> EigenDense eigenfact -> eigfact Hessenberg -> HessenbergDense Includes doc updates for linalg as well.
@ViralBShah Because the sparse matrix factorizations from umfpack.jl and cholmod.jl use the same names as those in factorization.jl I suggest that they be documented in linalg.rst too and will add those. Also, I thing the description of the \ operator is inaccurate. The Hermitian case uses the BunchKaufman factorization, not the Cholesky factor. I will go ahead and add the documentation of the sparse matrix factorizations unless you feel they would be better addressed in the sparse.rst file. |
Here are my comments to the linalg documentation
|
Could you modify the docs? All good stuff. |
c01415e updates the docs |
@andreasnoackjensen I have made updates to the documentation on master, but it would be great if you can review it.
Would it be ok to rename
eigenfact
toeigfact
and the type toEigenDense
, to keep the naming scheme consistent? I realized this while trying to document things.@dmbates - Yes, I know your views on consistentcy. ;-) Jokes aside, could you also take a look the dense linear algebra documentation, and make suggestions for improvement. It would be much easier to take a crack at sparse linear algebra documentation then.
The text was updated successfully, but these errors were encountered: