-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop supporting bases > 36 without explicit alphabet? #26571
Comments
Actually this might be the real issue:
We use 36 as the default base for parsing Chars, and 10 elsewhere. I think we should change the default to 10 everywhere. |
The method |
Even in base < 36, there is not always a strictly direct 1 to 1 mapping to a digits + hexa base. Ex: base32 crockford = base36 - https://github.com/JuliaLang/julia/blob/master/base/parse.jl#L36-L44 seems a bit too much hardcoded |
@JeffBezanson It seems that there's still no docstring for the |
https://discourse.julialang.org/t/what-is-the-effect-of-parse-on-char-types/9874/2
The fact that we have this seems like asking for trouble:
Perhaps it would be best to stop supporting bases larger than 36 since it's standard to parse hex in a case insensitive manner. At the very least we should make sure that we audit all the places where we print and parse bases larger than 36 and make sure that they're all internally consistent at least.
The text was updated successfully, but these errors were encountered: