Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support keys(::IOContext) #37701

Closed
simeonschaub opened this issue Sep 22, 2020 · 0 comments · Fixed by #37753
Closed

support keys(::IOContext) #37701

simeonschaub opened this issue Sep 22, 2020 · 0 comments · Fixed by #37753
Labels
display and printing Aesthetics and correctness of printed representations of objects.

Comments

@simeonschaub
Copy link
Member

simeonschaub commented Sep 22, 2020 •
edited
Loading

Since IOContext supports getindex and haskey, I think it would make sense to have keys return a (lazy) iterator as well. Since IOContext is not iterable, we can't use KeySet, but it should still be pretty straightforward to implement. It would just need to return keys(io.dict).
@rfourquet rfourquet added the display and printing Aesthetics and correctness of printed representations of objects. label Sep 23, 2020
simeonschaub added a commit to simeonschaub/julia that referenced this issue Sep 25, 2020
@simeonschaub
fix JuliaLang#37701: support keys(::IOContext)
35d4c06
@simeonschaub simeonschaub mentioned this issue Sep 25, 2020
Merged
simeonschaub added a commit to simeonschaub/julia that referenced this issue Oct 16, 2020
@simeonschaub
fix JuliaLang#37701: support keys(::IOContext)
76428fd
JeffBezanson pushed a commit that referenced this issue Oct 26, 2020
@simeonschaub
fix #37701: support keys(::IOContext) (#37753)
c293757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #37701: support keys(::IOContext) simeonschaub/julia
2 participants
@simeonschaub @rfourquet