-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing matrix division dispatches #502
Comments
The file is |
AbstractArray/Number and Number/AbstractArray, but not AbstractArray/AbstractArray are in abstractarray.j; array.j doesn't seem to define matrix division either. I also checked linalg.j. I can see that it actually works, though, as long as the number types line up. (We need a debugger!) |
We definitely need a debugger. Jeff and I concocted a plan for a debugger which basically involved JITing debug versions of code with debug hooks inserted into the AST at appropriate places. This is kind of similar to how I believe the perl debugger works. |
LLVM has debugging capabilities for JIT with gdb. We could probably make use of that. |
Matrix division stuff is in linalg_lapack.j. Just need to add a bunch of methods that do the right promotions. |
Excellent, found it. Thanks for the pointer, Viral! |
Since `eweights` is now being exported we should bump the minor version number
There's no dispatch for matrix division between Int32 and Float64, and probably others.
After watching Jeff's presentation, I was feeling confident I could figure out how to fix it. Unfortunately my grep-fu is failing me and I can't track down where AbstractMatrix/AbstractMatrix is defined. Any pointers?
The text was updated successfully, but these errors were encountered: