Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg should not shell out for filesystem calls #7041

Closed
vtjnash opened this issue May 30, 2014 · 2 comments · Fixed by #7046
Closed

Pkg should not shell out for filesystem calls #7041

vtjnash opened this issue May 30, 2014 · 2 comments · Fixed by #7046
Labels
bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows
Milestone
0.3.0

Comments

@vtjnash
Copy link
Member

vtjnash commented May 30, 2014

https://groups.google.com/d/msg/julia-users/xtPYujGOA94/XJlULPQdb-MJ

We have a perfectly good, cross-platform Base.mv function. There's no need to shell out to something that may not exist.
@vtjnash vtjnash added this to the 0.3 milestone May 30, 2014
hayd added a commit to hayd/julia that referenced this issue May 30, 2014
@hayd
FIX don't shell out mv or rmdir JuliaLang#7041
670a7b2
@hayd hayd mentioned this issue May 30, 2014
Merged
@quinnj quinnj mentioned this issue Jun 5, 2014
Closed
@JeffBezanson JeffBezanson reopened this Jun 9, 2014
@JeffBezanson
Copy link
Member

reopening for rm and rmdir

@hayd
Copy link
Member

hayd commented Jun 9, 2014

Also some calls ln here (#4396 creates function for this but only fixes one example). ls and chmod (to create a file) are used once or twice.

@StefanKarpinski StefanKarpinski mentioned this issue Jun 11, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

FIX don't shell out when you can mv hayd/julia
3 participants
@vtjnash @JeffBezanson @hayd