Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testname selection into a callable function #10214

Merged
merged 2 commits into from
Feb 17, 2015
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 16, 2015

This makes it much easier for CoverageBase to stay in sync with base. See #9493 (comment), which is still happening despite helpful efforts to keep it in sync (JuliaCI/CoverageBase.jl#2).

@tkelman
Copy link
Contributor

tkelman commented Feb 16, 2015

Needs rebasing already. Will also cause a lot of churn in every open PR that adds a test. And needs to update CONTRIBUTING.md if the list of tests is going to move.

"nullable", "meta", "profile", "libgit2", "docs", "markdown",
"base64", "parser", "serialize", "functors", "char", "misc"
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace here, possibly elsewhere too

@timholy
Copy link
Member Author

timholy commented Feb 16, 2015

Of open PRs labeled test, only one (#9674) appears to touch runtests.jl. I'd be fine if that one gets merged first, but it's not mergable as-is (even without this).

@andreasnoack
Copy link
Member

#10180 and 4f4dd62 touch runtests.jl but the the rebases should hopefully be smooth.

@timholy
Copy link
Member Author

timholy commented Feb 16, 2015

Those are both in, so I'll rebase mine on top of those.

This makes it much easier for CoverageBase to stay in sync
with base.
@tkelman
Copy link
Contributor

tkelman commented Feb 16, 2015

@timholy I'm curious, did you (or someone else) manually cancel the pending AppVeyor builds of the older commit here, or is this something that AppVeyor is doing for us automatically now? I have code that checks and fails quickly when there are newer pending builds for the same PR, so manually cancelling only saves a minute or so in queue time.

@timholy
Copy link
Member Author

timholy commented Feb 16, 2015

I did it manually.

@tkelman
Copy link
Contributor

tkelman commented Feb 16, 2015

Ah, okay. That isn't generally necessary unless you're really gung-ho about saving the minute or so that my code takes to stop the build.

The latest run here froze on AppVeyor during compilation of C code due to some recent makefile changes (see discussion here e85a1a5#commitcomment-9756164), so I restarted it.

@timholy
Copy link
Member Author

timholy commented Feb 16, 2015

Forgot about that; I won't worry about it in the future.

@timholy
Copy link
Member Author

timholy commented Feb 17, 2015

OK, this is green. If I don't hear any objections, I'll merge this very soon (to avoid further churn for other PRs that modify runtests.jl).

timholy added a commit that referenced this pull request Feb 17, 2015
Make testname selection into a callable function
@timholy timholy merged commit 6a58510 into master Feb 17, 2015
@timholy timholy deleted the teh/testnames branch February 17, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants