-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make testname selection into a callable function #10214
Conversation
Needs rebasing already. Will also cause a lot of churn in every open PR that adds a test. And needs to update CONTRIBUTING.md if the list of tests is going to move. |
"nullable", "meta", "profile", "libgit2", "docs", "markdown", | ||
"base64", "parser", "serialize", "functors", "char", "misc" | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace here, possibly elsewhere too
f35ec99
to
68eccff
Compare
Of open PRs labeled |
Those are both in, so I'll rebase mine on top of those. |
This makes it much easier for CoverageBase to stay in sync with base.
68eccff
to
71ea0c2
Compare
@timholy I'm curious, did you (or someone else) manually cancel the pending AppVeyor builds of the older commit here, or is this something that AppVeyor is doing for us automatically now? I have code that checks and fails quickly when there are newer pending builds for the same PR, so manually cancelling only saves a minute or so in queue time. |
I did it manually. |
Ah, okay. That isn't generally necessary unless you're really gung-ho about saving the minute or so that my code takes to stop the build. The latest run here froze on AppVeyor during compilation of C code due to some recent makefile changes (see discussion here e85a1a5#commitcomment-9756164), so I restarted it. |
Forgot about that; I won't worry about it in the future. |
OK, this is green. If I don't hear any objections, I'll merge this very soon (to avoid further churn for other PRs that modify |
Make testname selection into a callable function
This makes it much easier for CoverageBase to stay in sync with base. See #9493 (comment), which is still happening despite helpful efforts to keep it in sync (JuliaCI/CoverageBase.jl#2).