-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
rename MemoryError -> OutOfMemoryError #10503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
1 similar comment
+1 |
To be conservative, there should probably be an alias for the old name in |
Good point, added |
The OSX build on travis had a timeout. Is there a better way to trigger a pull request rebuild than by pushing a dummy commit like I just did? |
I'm able to restart the build from the Travis webpage, but maybe you need rights to do that. If not, then you can always force-push the same commit, only updating the date: |
Oh, and you can remove that commit using |
thanks for the hint! |
+1 to this |
Seems reasonable to me. @JeffBezanson, any opinion on the name change? |
Fine by me. |
rename MemoryError -> OutOfMemoryError
While it is clear to the core devs what a
MemoryError
is and this might feel like bike-sheddding, I believe that this will considerably improve the clarity of the error message for beginners.This can turn the user experience of "I get these random internal memory errors. Julia is so not stable yet." into "I see, not enough memory. Will try with less data then."
Had to invest a couple of hours myself, trying to debug these elusive
MemoryError
s which only occured on specific machines, while the root cause was so simple and my own fault.