Suppress deprecation warning when building sys0 #10728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings are printed to STDERR, which is unavailable while building a sysimg, resulting in any deprecation warnings while loading a module failing the entire build. This is only an issue for deprecated code at the module level, eg, in constants or macros.
vtjnash
changed the title
|
Thanks - I made a different fix in b9e165b so that this will also apply when people run imaging manually. |
|
Awesome, that's a much better fix. And thanks for correcting the title, I really wasn't sure if sysimg was the right name for it. |
|
Will this make it any harder to find and fix deprecations in base moving forward? Would there be any way to have these only ignored while building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10727.
Warnings are printed to STDERR, which is unavailable while building a
sysimg, resulting in any deprecation warnings while loading a module
failing the entire build. This is only an issue for deprecated code at
the module level, eg, in constants or macros.