Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only visit module parent when it is not NULL #11626

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Only visit module parent when it is not NULL #11626

merged 1 commit into from
Jun 9, 2015

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Jun 9, 2015

This can happen during bootstrap.

@carnaval

This is the first bug discovered with #11358 . (Sadly?) Not a very interesting one...

@yuyichao
Copy link
Contributor Author

yuyichao commented Jun 9, 2015

The environment variable (with #11358 and WITH_GC_DEBUG_ENV=1) settings are JL_GC_ALLOC_PRINT=0:1000 JL_GC_ALLOC_POOL=0 JL_GC_ALLOC_OTHER=0 (when building inference0).

@yuyichao
Copy link
Contributor Author

yuyichao commented Jun 9, 2015

And just for the record. Ref #11395 , 675f156

@carnaval
Copy link
Contributor

carnaval commented Jun 9, 2015

Thanks. I'll have a look at #11358 today.

carnaval added a commit that referenced this pull request Jun 9, 2015
@carnaval
Merge pull request #11626 from yuyichao/module-parent
e8302b2 
Only visit module parent when it is not NULL
@carnaval carnaval merged commit e8302b2 into JuliaLang:master Jun 9, 2015
@yuyichao yuyichao deleted the module-parent branch June 11, 2015 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyichao @carnaval