Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UnitRange's stop field for release-0.3 #12692

Merged
merged 1 commit into from
Aug 20, 2015
Merged

fix UnitRange's stop field for release-0.3 #12692

merged 1 commit into from
Aug 20, 2015

Conversation

mzaffalon
Copy link
Contributor

backport from 0.4.0 of unitrange_last, fixes #12534
added tests

Verified

This commit was signed with the committer’s verified signature.
tniessen Tobias Nießen
backport from 0.4.0 of unitrange_last, fixes #12534
added tests
@tkelman
Copy link
Contributor

tkelman commented Aug 19, 2015

Cool, thanks for this. @StefanKarpinski could you take a quick look and say off the top of your head whether this might break or change anything that's currently working on 0.3? It looks okay to me but I wouldn't mind a second opinion.

@nalimilan
Copy link
Member

Thanks for the PR. It would be good to mention in the commit message that this copies code from 0.4, and add "fixes #12692" so that the issue is automatically closed after merging.

EDIT: I don't know how I missed that you did that already.

@StefanKarpinski
Copy link
Member

@JeffBezanson, this was your change. Does this seem safe to you?

@mzaffalon
Copy link
Contributor Author

It looks like instead it was reported in #10950, but was not backported (#11261).

@tkelman
Copy link
Contributor

tkelman commented Aug 19, 2015

Ah. Well you managed to do it differently than I tried, and according to CI you've avoided the issue I hit.

@mzaffalon
Copy link
Contributor Author

This also mean that I git bisected wrong and you (@tkelman) were right in finding #10452 weird as the responsible.

JeffBezanson added a commit that referenced this pull request Aug 20, 2015

Verified

This commit was signed with the committer’s verified signature.
tniessen Tobias Nießen
fix UnitRange's stop field for release-0.3
@JeffBezanson JeffBezanson merged commit 24138e7 into JuliaLang:release-0.3 Aug 20, 2015
@mzaffalon mzaffalon deleted the zaf/fix12534 branch August 20, 2015 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants