Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Catalan's constant so Catalan numbers can be defined more na… #12706

Closed
wants to merge 1 commit into from
+5 −12
Closed

Renaming Catalan's constant so Catalan numbers can be defined more na… #12706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/exports.jl
View file
Original file line number Diff line number Diff line change
@@ -203,7 +203,6 @@ export
π, pi,
e, eu,
γ, eulergamma,
catalan,
φ, golden,
I,

9 changes: 4 additions & 5 deletions base/irrationals.jl
View file
Original file line number Diff line number Diff line change
@@ -101,11 +101,10 @@ big(x::Irrational) = convert(BigFloat,x)

## specific irriational mathematical constants

@irrational π 3.14159265358979323846 pi
@irrational e 2.71828182845904523536 exp(big(1))
@irrational γ 0.57721566490153286061 euler
@irrational catalan 0.91596559417721901505 catalan
@irrational φ 1.61803398874989484820 (1+sqrt(big(5)))/2
@irrational π 3.14159265358979323846 pi
@irrational e 2.71828182845904523536 exp(big(1))
@irrational γ 0.57721566490153286061 euler
@irrational φ 1.61803398874989484820 (1+sqrt(big(5)))/2

# aliases
const pi = π
1 change: 0 additions & 1 deletion contrib/julia.xml
View file
Original file line number Diff line number Diff line change
@@ -319,7 +319,6 @@
<item> eu </item>
<item> γ </item>
<item> eulergamma </item>
<item> catalan </item>
<item> φ </item>
<item> golden </item>
</list>
4 changes: 0 additions & 4 deletions doc/stdlib/numbers.rst
View file
Original file line number Diff line number Diff line change
@@ -181,10 +181,6 @@ General Number Functions and Constants

The constant e

.. data:: catalan

Catalan's constant

.. data:: γ
eulergamma

2 changes: 1 addition & 1 deletion test/rounding.jl
View file
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@ end
for T in [Float32,Float64]
for v in [sqrt(big(2.0)),-big(1.0)/big(3.0),nextfloat(big(1.0)),
prevfloat(big(1.0)),nextfloat(big(0.0)),prevfloat(big(0.0)),
pi,e,eulergamma,catalan,golden,
pi,e,eulergamma,golden,
typemax(Int64),typemax(UInt64),typemax(Int128),typemax(UInt128),0xa2f30f6001bb2ec6]
pn = T(v,RoundNearest)
@test pn == convert(T,BigFloat(v))