Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define svdvals(::SVD) #12747

Merged
merged 1 commit into from
Aug 22, 2015
Merged

Define svdvals(::SVD) #12747

merged 1 commit into from
Aug 22, 2015

Conversation

jiahao
Copy link
Member

@jiahao jiahao commented Aug 22, 2015

This method includes a type assertion to avoid the unfortunate type
instability of getindex(::SVD), which arises since :S is a vector while
:U, :V are matrices.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
This method includes a type assertion to avoid the unfortunate type
instability of getindex(::SVD), which arises since :S is a vector while
:U, :V are matrices.
@kshyatt kshyatt added the linear algebra Linear algebra label Aug 22, 2015
@stevengj
Copy link
Member

LGTM.

jiahao added a commit that referenced this pull request Aug 22, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Define svdvals(::SVD)
@jiahao jiahao merged commit f77d7eb into master Aug 22, 2015
@jiahao jiahao deleted the cjh/svdvals-svd branch August 22, 2015 15:25
jiahao added a commit that referenced this pull request Aug 22, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Ref: #3021 #12747
jiahao added a commit that referenced this pull request Aug 22, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Ref: #3021 #12747
jiahao added a commit that referenced this pull request Aug 22, 2015

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Ref: #3021 #12747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants