add missing eachindex method for indexable collections: SimpleVector, Tuple, and Number #12797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Tuple, and Number
| @@ -18,6 +18,7 @@ getindex(x::Number, I::Real...) = getindex(x, to_indexes(I...)...) | |||
| unsafe_getindex(x::Real, i::Real) = x | |||
| first(x::Number) = x | |||
| last(x::Number) = x | |||
| eachindex(x::Number) = 1 | |||
There was a problem hiding this comment.
this definition seems nicely meta: "the list of indices for iterating over a number can be found by iterating over the number 1"
|
it looks like the travis failure was due to some transient network issue (fatal: unable to access 'https://github.com/JuliaLang/Example.jl.git/': Failed connect to github.com:443; Operation timed out) |
|
restarted travis... |
|
Seems to be obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few missing
eachindexmethods for indexable collections that I noticed in #12788.I think the principle is that any iterable collection that implements
getindexshould implementeachindex, to enable the writing of generic code for such indexable collections. That includesSimpleVector(used for low-level stuff likeDataType.types),Tuple, andNumber(since numbers are indexable collections in Julia, primarily to make it easy to write generic code that works for both vectors and scalars).