Fix #13823, add logabsdet for complex matrices #14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,11 +22,11 @@ for elty in (Int, Rational{BigInt}, Float32, Float64, BigFloat, Complex{Float32} | |||
| debug && println("element type: $elty") | |||
|
|
|||
| @test_approx_eq logdet(A) log(det(A)) | |||
| @test_approx_eq logabsdet(A)[1] log(abs(det(A))) | |||
| @test logabsdet(A)[2] ≈ sign(det(A)) | |||
There was a problem hiding this comment.
could this test exact equality for real and approx for complex?
|
👍 |
kshyatt
force-pushed
the
ksh/logabsdet
branch
from
5bb2d30 to
9e79f88
Compare
|
lgtm |
kshyatt
added a commit
that referenced
this pull request
Dec 1, 2015
Fix #13823, add logabsdet for complex matrices
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2017
rofinn
pushed a commit
to invenia/julia
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion over at JuliaLang/LinearAlgebra.jl#277, I added
logabsdetforComplextypes. I changed the test a little bit to make sure thesigns will match (they are only ever not exactly the same for the complex matrices).