-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Rename super() to supertype() #14338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm in favor of this rename, but I suspect we should wait until after potential shakeup due to adding protocols and/or traits. |
Why not, but this doesn't strike me as really affecting the same code, nor requiring the same kind of change. |
Eh, that's fair. I guess I'm just wondering somewhere if the whole notion of |
I'm fine with waiting for a bit until we know whether abstract types might go away completely. |
They are not anytime soon. |
supertype is an easy preference and super(x) should be reflexively assignable |
Also, I think based on my understanding of the proposals, although I might be wrong, but supertype would still be a helpful utility function regardless of the changes (even the proposal technically removing abstract types would still have use for a function named supertype). |
+1 |
This name is more explicit and consistent with subtypes(). Also rename promote_to_super() for consistency, but without deprecation as it isn't exported.
b47077a
to
df648f1
Compare
No problem. I've rebased it and will merge when the tests pass. |
please don't restart failed travis jobs without making a note and saving the log. |
Sorry, I always forget that Travis doesn't keep the log available. |
Rename super() to supertype()
This name is more explicit and consistent with subtypes().
Also rename promote_to_super() for consistency, but without
deprecation as it isn't exported.
Fixes #14337.