Fix attempt to index Ref at position 1 in ggsvd3! #15883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrectly backported in e3f3f72. Similar patterns in the file use Array instead of Ref in 0.4.
|
It's slightly better to fix the macro to accept both but this should be fine too.... |
|
I tried to keep the backported code consistent with the original one. On master, things are quite different now anyway. |
|
thanks! |
| k = Ref{BlasInt}() | ||
| l = Ref{BlasInt}() | ||
| k = Array(BlasInt, 1) | ||
| l = Array(BlasInt, 1) |
There was a problem hiding this comment.
Strictly speaking I guess k and l were okay using Ref since none of the macros were referring to them, and it might look a little more natural below to use k[1] instead of k[] now if it's going to be an Array, but for now it's the same.
There was a problem hiding this comment.
Yes, they were fine, but I realized all other calls used an array, so better be consistent. But indeed I could have changed [] to [1] too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrectly backported in e3f3f72. Similar patterns in the file
use Array instead of Ref in 0.4.
Fixes #15733.