make flush(stream) return nothing #16076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bicycle1885
force-pushed
the
flush-return-nothing
branch
from
dd34186 to
166115b
Compare
|
Updated tests. |
|
Could anyone give me 👍 or 👎 to my idea and/or pull request? |
|
Seems ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
flush(stream)function returnsstreamornothingdepends on the type ofstreamargument. For example,flush(::TextTerminal)andflush(::DevNullStream)will returnnothingbutflush(::IOStream)andflush(::BufferStream)will return the first argument. This pull request fixes the inconsistency and makes it always returnnothing. It is also reasonable to make it return the first argument, but it is not quite useful.Exactly speaking, this is a breaking change, but I believe nobody depends on this behavior and will not break any code.