Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create beta.jl #16177

Closed
wants to merge 1 commit into from
Closed

Create beta.jl #16177

wants to merge 1 commit into from

Conversation

cossio
Copy link
Contributor

@cossio cossio commented May 3, 2016

Added incomplete beta function and its logarithm to Base.

@cossio
Copy link
Contributor Author

cossio commented May 3, 2016

This implementation is based on a continued fraction expansion from the Numerical Recipes.

@cossio
Copy link
Contributor Author

cossio commented May 3, 2016

I want to improve it (I use this myself), so any comments appreciated.

@kmsquire
Copy link
Member

kmsquire commented May 3, 2016

Hi @cossio, thank you for the contribution. Unfortunately, the Numerical Recipes license forbids source code implementations from being distributed in source form (see http://numerical.recipes/licenses/redistribute.html), so we won't be able to include this implementation in Julia.

@kmsquire kmsquire closed this May 3, 2016
@cossio
Copy link
Contributor Author

cossio commented May 3, 2016

@kmsquire This does not copy the numerical recipes code. Note that the numerical recipes code computes the incomplete Beta function. I modified this to compute the logarithm of the incomplete beta function, which required (in my judgement), a substantial rewrite. I only reference to Numerical Recipes for an explanation, but the code is definitely not a copy. But I leave it to your judgement.

@StefanKarpinski
Copy link
Member

Unfortunately, that almost certainly qualifies as a derived work, meaning we cannot use it. Legal stuff is quite annoying, but unfortunately also important to be careful about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants