More promote_op fixes #17114
Closed
More promote_op fixes #17114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously triggered a stack overflow due to recursive definition.
Use common promote_op() based on one() for all Number types:
this fixes promote_op(+, ::Bool), which returned Int, and
promote_op(==, ::Complex, ::Complex), which returned Complex{Bool}.
Also fix a few corner cases which did not work or were type-instable.
Add systematic tests to catch this kind of bug.
| @test @inferred([m m].*[m,m]) == [m2 m2; m2 m2] | ||
| convert{T<:Real,pow}(::Type{MeterUnits{T,pow}}, y::Real) = MeterUnits{T,pow}(convert(T,y)) | ||
|
|
||
| @test m+[m,m] == [m+m,m+m] |
There was a problem hiding this comment.
Why remove the @inferred calls?
There was a problem hiding this comment.
I made a mistake while copying some of the code I tested locally. Is fixed now.
|
Thanks! Though @JeffBezanson is the one to ask... Ref: #16995 |
Merged
nalimilan
force-pushed
the
nl/promote_op
branch
2 times, most recently
from
21bc568 to
9df4f1a
Compare
|
I've picked your commit into #16995, let's continue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nalimilan
Note: This PR is against branch
nl/promote_opinstead ofmaster