Add test for Issue #17153 and PR #17154 #17164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wait, I guess @simonbyrne already had a test for this. So this is unnecessary, I suppose. |
|
still likely valuable for coverage reasons if nothing else, since these look a little different than the tests from #17154 |
|
And please mention what is this testing, not just the issue/pr numbers..... |
|
@yuyichao I have edited my comment. Will do so from next time onwards. :) |
|
OK for this time. Would be good to include that in the first line of the commit message. |
|
I guess the only bug here was the whitespaces. |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
…17164) * Add test for Issue JuliaLang#17153 and PR JuliaLang#17154 * Fix whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for Issue #17153 and PR #17154, where there was a bug where
medianwas mutating the input array. Add a simple test to make sure these functions do not become mutating.cc: @simonbyrne , @StefanKarpinski