-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More HelpDB pruning for Bit/SparseArray, more examples #17797
Conversation
268c8cf
to
956326c
Compare
Scanning rapidly, the sparse-related changes lgtm! |
""" | ||
ror!(dest::BitVector, src::BitVector, i::Integer) -> BitVector | ||
|
||
Performs a right rotation operation on `src` and put the result into `dest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and puts the result
Yet MORE examples from the REPL. Fixed and added links, changd some wording.
Removed calls to `rand` in the doctests.
16de94c
to
fdef48d
Compare
Rebased against |
@@ -187,7 +187,7 @@ Constructors | |||
|
|||
Create an array of all zeros with the same element type and shape as ``A``\ . | |||
|
|||
.. function:: ones([T::Type=Float64,] dims) | |||
.. function:: ones(type, dims) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eltype?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored this back to the way it was originally. Getting this to work with the @eval
loop was basically impossible because sysimg.jl
loads string.jl
after array.jl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can always add empty signatures outside the loop just for the purpose of attaching the docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and it didn't work, because we have two ones
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be a syntax to attach the same docstring to 2 methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you have it backwards. We have two docstrings for one method if you use the empty signatures.
|
Yet MORE examples from the REPL. Fixed and added links,
changd some wording.