Move datafmt docs out, update them a bit #17843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
| @@ -624,7 +624,7 @@ Text I/O | |||
|
|
|||
| The columns are assumed to be separated by one or more whitespaces. The end of line delimiter is taken as ``\n``\ . If all data is numeric, the result will be a numeric array. If some elements cannot be parsed as numbers, a heterogeneous array of numbers and strings is returned. | |||
|
|
|||
| .. function:: writedlm(f, A, delim='\\t') | |||
| .. function:: writedlm(f, A, dl='\\t'; opts) | |||
There was a problem hiding this comment.
why delim everywhere but here?
There was a problem hiding this comment.
Because in the arg list it's dl. I can change it back :)
There was a problem hiding this comment.
yeah I think doc consistency will be more visible than code naming consistency. we could change the latter too if we feel like it.
There was a problem hiding this comment.
ty for the reminder i will take care of it tonight :)
| """ | ||
| writedlm | ||
| digamma |
There was a problem hiding this comment.
you moved the docstring for digamma already, I think adding it back was a rebase mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docstrings could stand some real improvement so if someone has suggestions, I'm happy to update them (or you can just push to my branch).