Move documentation inline for error types declared in base/base.jl. #17959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,15 +4,32 @@ type SystemError <: Exception | |||
| prefix::AbstractString | |||
| errnum::Int32 | |||
| extrainfo | |||
| @doc """ | |||
| SystemError(prefix::AbstractString, [errno::Int32]) | |||
There was a problem hiding this comment.
3-space indent here, should be 4 to be recognised as a code block.
💯 |
|
|
|
Only 7869 lines to go! |
tkelman
added
docs
|
Great, I made the modifications suggested. Thank you for the feedback @MichaelHatherly! |
|
This was on my to-do list and you beat me! Nice work! 💯 |
| AssertionError(msg) = new(msg) | ||
| AssertionError() = new("") |
There was a problem hiding this comment.
Changing the definition order probably won't affect anything, but best to avoid unrelated changes if possible. Other than that the PR looks go to me, thanks.
|
Also, @xorJane, this is your second Julia PR, right? (Belated) Welcome to Julia if so! |
|
Thanks @kshyatt ! |
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved the documentation inline for types
SystemError,ParseError,ArgumentError,KeyError,MethodError,EOFError,DimensionMismatch,AssertionError,LoadError, andInitError. Hope that helps!