increase default maximum number of openblas threads on power #18638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the impact on stack use? |
vtjnash
requested changes
Sep 22, 2016
|
also #14857 and JuliaLang/LinearAlgebra.jl#323 |
vchuravy
force-pushed
the
vc/power_openblas
branch
from
5af40b1 to
682e68a
Compare
|
Okay let's be conservative for now and go with @xianyi suggestion of 24 threads. Re: #14857 (comment) |
|
I think we can just suggest that users customize their BLAS build in Make.user if they have custom (e.g. very large) matrices and very large machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are defaulting to a hard-limit to 8. Which makes a decent size power node sad.
The question is what a realistic limit is and @xianyi suggested at least 24, while I went to the maximum number of cores currently available.