Doc fixes #19701
Merged
Doc fixes #19701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
added
docs
tkelman
approved these changes
Dec 23, 2016
I'm going to try see if I can get doctests running on each build in this PR. That should stop things like backtrace line numbers becoming stale. There's a 265-related fix in Documenter that I need to tag first though that's blocking running |
|
I think line numbers will get annoying to keep changing on master, we can ignore those until release branches. Maybe we should take "running doctests on CI" one step at a time to see how it works day to day? |
|
Ok, small steps are fine too. I'll just push the doc version bump and a couple of doctest fixes here, but leave turning on doctests for another time. |
JuliaLang#19635 merged two docstrings for each of `zeros` and `ones` in a single docstring each. This changes the signatures in the stdlib file to reflect that change.
This avoids an error that occurs when documentaion dep versions have been updated, but `Pkg.update` hasn't been called which results in `Pkg.resolve` not being able to find suitable package versions.
This should make travis builds on PRs fail when changes are made that cause `doc/make.jl` to raise warnings that need to be addressed prior to merging.
Fixes docs builds on 32bit platforms.
MichaelHatherly
force-pushed
the
mh/doc-fixes-4
branch
from
0e19b4a to
90003ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdlib/arrays.mdfor changes to docstring signatures made in Zeros #19635;Pkg.resolveandPkg.updateto hopefully solve an error encountered by @kshyatt;strict = trueto change doc errors/warnings prior to merging PRs.