fix return value of typeinf_code for code == nothing
#20068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that seems to do it: @generated function construct_similar{FSA <: Tuple}(::Type{FSA}, elements::Tuple)
:(FSA)
end
code_typed(construct_similar, (DataType, Tuple{Int, Int})) |
|
thanks! :) |
vchuravy
force-pushed
the
vc/fixup_typeinf_code
branch
from
6c96923 to
d129379
Compare
|
Is it possible to trigger this without |
|
I seem to be only able to trigger that code-path with |
vchuravy
force-pushed
the
vc/fixup_typeinf_code
branch
from
d129379 to
a9949be
Compare
|
@vtjnash ok to merge? |
| @generated function foo20067{T <: Tuple}(::Type{T}, elements::Tuple) | ||
| :(T) | ||
| end | ||
| code_typed(DevNull, foo20067, (DataType, Tuple{Int, Int})) |
There was a problem hiding this comment.
There is no 3-argument code_typed. Unfortunately this test failure was masked by #20027.
It would also be better if there were a @test in here.
There was a problem hiding this comment.
Inference also fails here, I believe because it doesn't want to call the generated function on an abstract type (Type{T} where T<:Tuple).
There was a problem hiding this comment.
Sorry about that, I noticed that and then promptly forgot to fix it...
It might be best to remove the test for now. #20146
vchuravy
added a commit
that referenced
this pull request
Jan 20, 2017
JeffBezanson
added a commit
that referenced
this pull request
Jan 21, 2017
remove erroneous test for #20068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20067
@SimonDanisch what was the example that triggered this? Would be good as a test case.