Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export println_with_color #20176

Closed
wants to merge 1 commit into from
Closed

export println_with_color #20176

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

Fixes #10327

@tkelman
Copy link
Contributor

tkelman commented Jan 22, 2017

quoting jeff

Generally underscores are unsatisfying. print_color should ideally be separated into two concepts: print and color

would be better to deprecate print_with_color and have a composable api for color output

to export this it would have to go in the stdlib doc index and be tested.

@KristofferC
Copy link
Member Author

would be better to deprecate print_with_color and have a composable api for color output

Sure but that is a whole other project. Considering we have print, println, print_with_color it makes sense to have println_with_color. If someone later revamps the color printing, then that will of course change. Agree?

@KristofferC
Copy link
Member Author

Otherwise, please close this and #10327.

@KristofferC
Copy link
Member Author

Regarding a revamped color printing design, https://github.com/KristofferC/Crayons.jl would be my suggestion but it feels that with the push to move things out of base, it might be better to stay as a package.

@kshyatt kshyatt added the display and printing Aesthetics and correctness of printed representations of objects. label Jan 22, 2017
@tkelman tkelman deleted the kc/exp_println_color branch February 11, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants