-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix computation of range length in certain cases (fix #20373) #20377
Conversation
|
49e1f7a
to
c7311f7
Compare
Ok, there's a real 32-bit failure here on Linux & Windows. The stack traces seems to be junk, but the error is an InexactError, which may be from the |
66f4aef
to
f294001
Compare
32-bit failure is in the linspace constructor for random ranges, cc: @timholy. I'm just going to skip those tests in this PR since I haven't touched linspace at all, but I'm leaving a FIXME note and we should open a corresponding issue to fix this issue since the tests I added reveal a failure case. |
f294001
to
ff7bf3e
Compare
ff7bf3e
to
458f9e8
Compare
This PR should be squashed when merged to avoid a broken 32-bit commit in history. |
AppVeyor failure is unrelated, occurring after normal tests have passed (the ColorTypes thing). |
Sorry, I didn't follow this in real time. What was the |
Boy do we need #20005. It's one of those things that takes one person much more time than they get back, but collectively...sorry I haven't gotten around to finishing it. |
I opened an issue here: #20520. The backtraces are mostly unhelpful – they simply indicate some unknown |
No description provided.