Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computation of range length in certain cases (fix #20373) #20377

Merged
merged 2 commits into from
Feb 8, 2017

Conversation

StefanKarpinski
Copy link
Member

No description provided.

@kshyatt kshyatt added the collections Data structures holding multiple items, e.g. sets label Feb 2, 2017
@tkelman
Copy link
Contributor

tkelman commented Feb 2, 2017

why the skipped tests? x-ref to the specific comment describing them #20373 (comment)

@StefanKarpinski
Copy link
Member Author

Ok, there's a real 32-bit failure here on Linux & Windows. The stack traces seems to be junk, but the error is an InexactError, which may be from the floor(Int, ...) call. That was simply moved to a later point, so maybe it's something else, but this also adds tests that weren't being run before.

@StefanKarpinski
Copy link
Member Author

32-bit failure is in the linspace constructor for random ranges, cc: @timholy. I'm just going to skip those tests in this PR since I haven't touched linspace at all, but I'm leaving a FIXME note and we should open a corresponding issue to fix this issue since the tests I added reveal a failure case.

@StefanKarpinski
Copy link
Member Author

This PR should be squashed when merged to avoid a broken 32-bit commit in history.

@StefanKarpinski
Copy link
Member Author

AppVeyor failure is unrelated, occurring after normal tests have passed (the ColorTypes thing).

@StefanKarpinski StefanKarpinski merged commit e849169 into master Feb 8, 2017
@StefanKarpinski StefanKarpinski deleted the sk/frfix branch February 8, 2017 13:46
@timholy
Copy link
Member

timholy commented Feb 8, 2017

Sorry, I didn't follow this in real time. What was the linspace error? The links here to the test aren't revealing.

@timholy
Copy link
Member

timholy commented Feb 8, 2017

Boy do we need #20005. It's one of those things that takes one person much more time than they get back, but collectively...sorry I haven't gotten around to finishing it.

@StefanKarpinski
Copy link
Member Author

I opened an issue here: #20520. The backtraces are mostly unhelpful – they simply indicate some unknown InexactError that occurs in that block of tests. More informative is that fact that the failure goes away when I don't call linspace. Unfortunately, that's all I've got.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collections Data structures holding multiple items, e.g. sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants