Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small change to type intersection that fixes #20344 #20448

Merged
merged 1 commit into from
Feb 4, 2017
Merged

Conversation

JeffBezanson
Copy link
Member

I'm not sure how comprehensive this is but it fixes the example reported in #20344.

@andreasnoack
Copy link
Member

Great. I just tried this and it fixes the failures in StaticArrays and Distributions.

@tkelman
Copy link
Contributor

tkelman commented Feb 4, 2017

does it fix @nanosoldier runbenchmarks(ALL, vs = ":master") ?

@nanosoldier
Copy link
Collaborator

Something went wrong when running your job:

NanosoldierError: failed to run benchmarks against primary commit: ErrorException("failed process: Process(`sudo cset shield -e su nanosoldier -- -c ./benchscript.sh`, ProcessExited(1)) [1]")

Logs and partial data can be found here
cc @jrevels

@andreasnoack
Copy link
Member

It appears that the removal of the deprecations has broken Nanosoldier and Requests

JuliaCI/Nanosoldier.jl#27
JuliaWeb/Requests.jl#147

@nalimilan
Copy link
Member

Also fixes the StackOverflow error when loading CategoricalArrays.

@JeffBezanson JeffBezanson merged commit ae20130 into master Feb 4, 2017
@mlubin
Copy link
Member

mlubin commented Feb 4, 2017

Also fixes the crash in JuMP

@pabloferz pabloferz deleted the jb/20344 branch February 4, 2017 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants