Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible and fast date parsing #20952

Merged
merged 12 commits into from
Mar 16, 2017
+268 −114
Merged

Extensible and fast date parsing #20952

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
49143c5
Refactor date parsing to be fast and extensible
omus Mar 8, 2017
eac850f
Deprecate parse(::AbstractString, ::DateFormat)
omus Mar 8, 2017
c5bd3c3
fixup
omus Mar 8, 2017
ad19d23
Switch to datatype_name
omus Mar 10, 2017
d833ec4
Move towards consistent terminology
omus Mar 10, 2017
f85877e
Rename parse(::Vector, ...) to parse_components
omus Mar 10, 2017
529affe
Internal parse funcs now take and return position
omus Mar 10, 2017
c16d629
Documentation for internal functions
omus Mar 10, 2017
2b787f2
Corrections to documentation
omus Mar 13, 2017
b0f6c75
Corrections from review
omus Mar 13, 2017
17d8ecc
More details about raise
omus Mar 13, 2017
510dd02
Remove outdated comment
omus Mar 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch to datatype_name
@omus
omus committed Mar 10, 2017
commit ad19d232116b6c3ab21fa2dde3a49540d7572d2f
2 changes: 1 addition & 1 deletion base/dates/parse.jl
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ function directives{S,F}(::Type{DateFormat{S,F}})
return tokens, directive_index, directive_letters
end

genvar(t::DataType) = Symbol(lowercase(string(t.name.name)))
genvar(t::DataType) = Symbol(lowercase(string(Base.datatype_name(t))))


@generated function tryparse_core(str::AbstractString, df::DateFormat, raise::Bool=false)
Copy link
Contributor

@shashi shashi Mar 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great if this function can take a start index and return an end position... I've had to hack around this to get this. It's very useful when you're parsing dates and some more stuff after / a list of dates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be supported.