add NEWS.md entry for macro hygiene fix #21820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
May 12, 2017
tkelman
reviewed
May 12, 2017
NEWS.md
Outdated
| @@ -220,6 +220,9 @@ This section lists changes that do not have deprecation warnings. | |||
| `airybiprimex`, `airyaix`, `airybix`, `airyaiprimex`, `airybiprimex`) | |||
| ([#18050]). | |||
|
|
|||
| * When a macro is called in the module in which that macro is defined, global variables | |||
| in the macro are now correctly resolved in the macro definition environment ([#15850]). | |||
There was a problem hiding this comment.
since this was so breaking, we should mention what the symptoms and fix look like - usually undefined variable errors that didn't occur in 0.5, and a few more calls to esc, respectively
There was a problem hiding this comment.
Good call! How does the present iteration look? Roughly what you had in mind, or had you something else / additional in mind? Thanks!
| in the macro are now correctly resolved in the macro definition environment. Breakage | ||
| from this change commonly manifests as undefined variable errors that do not occur | ||
| under 0.5. Fixing such breakage typically requires sprinkling additional `esc`s in | ||
| the offending macro ([#15850]). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears #15850 from #21475 (comment). (Well, hopefully --- someone properly familiar with the macro hygiene fix in #15850 should check this news entry's wording!). Best!