- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make behavior of ^(::Matrix{<:Integer},::Integer)
consistent with behavior of ^(::Integer, ::Integer)
#23368
Merged
andreasnoack
merged 16 commits into
JuliaLang:master
from
afniedermayer:afniedermayer/fix23366
Aug 24, 2017
+65
−13
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
119bb9d
Make `^(::Matrix{S},::T) where {S<:Integer, T<:Integer}` type stable.…
afniedermayer b21baf2
Make `^(::Matrix{S},::T) where {S<:Integer, T<:Integer}` type stable.…
afniedermayer c7d3de1
Merge branch 'afniedermayer/fix23366' of https://github.com/afniederm…
afniedermayer c4e79d7
fix typo
afniedermayer 9fbe23f
fixed typo
afniedermayer 8267b1b
Adjust tests for `^(::Matrix{Int64},Int64)` for symmetric/hermitian …
afniedermayer b5b3bc7
avoid code duplication by using the same code for `^(::Matrix{<:Integ…
afniedermayer cd7a0a3
added specialized domain error message for
afniedermayer 56f5091
added specialized domain error message for
afniedermayer ba5b3ec
Merge branch 'afniedermayer/fix23366' of https://github.com/afniederm…
afniedermayer 76a33e2
reverted change in faq
afniedermayer 1a22961
different throw_domerr_powbysq for Any and Integer, simplified conver…
afniedermayer e996b78
Adjusted "Breaking changes" section of news
afniedermayer 0bf799c
split news item into two bullets
fredrikekre 7fb880b
remove unnecessary Base. qualification
fredrikekre e1c334d
remove more unnecessary Base. qualifications
fredrikekre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added specialized domain error message for
`^(::Matrix{<:Integer},::Integer)`, added `@inferred` and comments to test
commit 56f50914785e3e34a522c8f8fb21ef2b220cf659
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is generic function, it might make sense to make this message generic if it doesn't make it (much) less informative. What about just writing "Cannot raise an integer x to a negative power. Try converting input to float". We could keep this version but restrict the inputs to
Integer
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you mean three versions of
throw_domerr_powbysq
: for::Any
(short message),::Integer
(message above), and::AbstractMatrix
(message below)?