Differentiate between and process and timeout errors #24338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
error handling
omus
commented
Oct 26, 2017
test/TestHelpers.jl
Outdated
| sleep(timeout) | ||
| kill(p) | ||
| close(master) | ||
| end | ||
| try | ||
| for (challenge, response) in challenges | ||
| process_exited(p) && error("Too few prompts. $(format_output(out))") | ||
|
|
There was a problem hiding this comment.
I couldn't manage to trigger this error. Most of the time this loop is blocked by readuntil which will abend when the process is aborted and trigger the "Could not locate challenge" error.
omus
commented
Oct 27, 2017
test/TestHelpers.jl
Outdated
|
|
||
| # Process timed out or aborted | ||
| if !success(p) | ||
| if istaskdone(t) |
There was a problem hiding this comment.
Looking at this again there is a small timing window where the process could be killed externally and the time out task could end
|
Some additional changes:
|
omus
force-pushed
the
cv/challenge-process-error
branch
from
32ab46e to
8b7784a
Compare
|
Rebased changes. Hopefully the Circle CI test pass now. |
omus
force-pushed
the
cv/challenge-process-error
branch
from
8b7784a to
273e570
Compare
|
Rebased changes to re-run the CI. Will merge if successful. |
|
Travis CI failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a SIGKILL from the timeout task or signalled externally would both raise the same exception. This should assist in debugging #24329