Fix error in cglobal expressions created by macro with escaped literals #26504
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #26297 (#issuecomment-371165725), I made reference to a problem with
cglobal
expressions created by macros — as PyCall uses — on master. This PR is a [naive] attempt at fixing that issue (which I think ends up being distinct from the original error being reported in #26297).I don't actually know lisp so this is mostly just guessing, but some time spent with git grep and combinations of
@code_lowered
andMeta.expand()
, I maybe lucked in to a solution.With this (plus a lot of patience — see #26357) I was actually able to get a PyPlot window to show on master!
Before:
After: