Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowVector issue #24590 #26992

Closed
wants to merge 2 commits into from
Closed

RowVector issue #24590 #26992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afdee2
RowVector issue #24590
May 5, 2018
0b09fc2
Reviewed changes for dot.
alexandrebrilhante Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/src/rowvector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,7 @@ struct RowVector{T,V<:AbstractVector} <: AbstractMatrix{T}
end
end
const ConjRowVector{T,CV<:ConjVector} = RowVector{T,CV}

# Issue #24590: an inner product on a vector space induces an inner product on the dual space.
dot(x::Transpose{<:AbstractVector{<:Number}}, y::Transpose{<:AbstractVector{<:Number}}) = dot(transpose(x), transpose(y))
dot(x::Adjoint{<:AbstractVector{<:Number}}, y::Adjoint{<:AbstractVector{<:Number}}) = dot(adjoint(y), adjoint(x)) # note order (y,x): this is to get the correct conjugation
8 changes: 8 additions & 0 deletions stdlib/LinearAlgebra/test/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,4 +460,12 @@ end
@test B == A .* A'
end

@testset "Issue #24590" begin
for T in (Transpose, Adjoint)
@test dot(T([1, 2, 3, 4]), T([2, 3, 6, 10])) == 66
@test dot(T([1, 2, 3, 4]), (1+2im)*T([2, 3, 6, 10])) == (1+2im)*66
@test dot((1+2im)*T([1, 2, 3, 4]), T([2, 3, 6, 10])) == (1-2im)*66
end
end

end # module TestAdjointTranspose