Fix offset LinearIndices range indexing (fixes #27986) #28001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
approved these changes
Jul 9, 2018
base/indices.jl
Outdated
| @@ -364,14 +364,14 @@ IndexStyle(::Type{<:LinearIndices}) = IndexLinear() | |||
| axes(iter::LinearIndices) = map(indices1, iter.indices) | |||
| size(iter::LinearIndices) = map(unsafe_length, iter.indices) | |||
| function getindex(iter::LinearIndices, i::Int) | |||
| @_inline_meta | |||
| @_propagate_inbounds_meta | |||
There was a problem hiding this comment.
Propagate inbounds should only be needed if this function itself calls getindex — I think @inline should be correct here. Did you see this make a difference?
There was a problem hiding this comment.
Ah, you're right, I am rusty on that machinery. Will correct. Thanks for looking!
timholy
force-pushed
the
teh/sliceindexing
branch
from
99b9e56 to
d5392ac
Compare
andyferris
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @andyferris
Fixes #27986.