Add sincosd function #30134
+40
−1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1083,12 +1083,12 @@ Simultaneously compute the sine and cosine of `x`, where `x` is in degrees. | ||
| if isinf(x) | ||
| return throw(DomainError(x, "sincosd(x) is only defined for finite `x`.")) | ||
| elseif isnan(x) | ||
| return (oftype(x,NaN), oftype(x,NaN)) | ||
| end | ||
|
|
||
| # It turns out that calling those functions separately yielded better | ||
|
There was a problem hiding this comment. This is pretty surprising, any idea why? Part of the point of sincos, is it avoid the double cost of calling sin and cos on the same argument. There was a problem hiding this comment. I think the compiler is clever enough to remove those duplicated executions. There was a problem hiding this comment. In fact, the Line 208 in 8221c87 |
||
| # performance than considering each case and calling `sincos_kernel`. | ||
| return (sind(x), cosd(x)) | ||
| end | ||
|
|
||
| sincosd(::Missing) = (missing, missing) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't these conditions checked in
sindandcosd? Why check here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because without it, then the user will see an error on the function
sindifInfis passed. I though it could lead to confusion.With respect of
NaN, it can be removed. Do you want me to remove it? This was added when I was trying to make a function faster than calling both separated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do error checking like that elsewhere though.